Update multiple_buttons.rst #12089
Merged
Update multiple_buttons.rst #12089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Aug 6, 2019
| @@ -35,3 +35,9 @@ Or you can get the button's name by using the | |||
| if ($form->getClickedButton() && 'saveAndAdd' === $form->getClickedButton()->getName()) { | |||
| // ... | |||
| } | |||
|
|
|||
| If you have multiple buttons with the same name, each nested in multiple subforms, use direct reference instead the name to get the right button | |||
There was a problem hiding this comment.
I would clarify here that this is related to a form name used multiple times. And we could also just add it inside the code block above. Maybe something like this:
Or you can get the button's name by using the
:method:`Symfony\\Component\\Form\\Form::getClickedButton` method of the form::
if ($form->getClickedButton() && 'saveAndAdd' === $form->getClickedButton()->getName()) {
// ...
}
// if you have multiple buttons with the same name, compare the object references instead
if ($form->getClickedButton() === $form->get('saveAndAdd')){
// ...
}There was a problem hiding this comment.
Yes but multiple buttons with the same name in the same form is not possible, so I wanted to clarify that it was in nested form situation.
There was a problem hiding this comment.
Maybe using @xabbuh's proposal + a small note about the "same name"?
|
@Romaxx would you like to finish this PR? |
javiereguiluz
force-pushed
the
patch-1
branch
from
b76bcff to
194bca1
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 20, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #12089). Discussion ---------- Update multiple_buttons.rst Reference to symfony/symfony#32932 Commits ------- 194bca1 Update multiple_buttons.rst
|
@Romaxx thanks for contributing this improvement. I agreed both with you and @xabbuh so I reworded this as follows while merging: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to symfony/symfony#32932